pgsql: Drop no-longer-needed buffers during ALTER DATABASE SET TABLESPA

Lists: pgsql-committers
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Drop no-longer-needed buffers during ALTER DATABASE SET TABLESPA
Date: 2014-11-04 18:25:17
Message-ID: E1Xlin7-0003wT-Ll@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Drop no-longer-needed buffers during ALTER DATABASE SET TABLESPACE.

The previous coding assumed that we could just let buffers for the
database's old tablespace age out of the buffer arena naturally.
The folly of that is exposed by bug #11867 from Marc Munro: the user could
later move the database back to its original tablespace, after which any
still-surviving buffers would match lookups again and appear to contain
valid data. But they'd be missing any changes applied while the database
was in the new tablespace.

This has been broken since ALTER SET TABLESPACE was introduced, so
back-patch to all supported branches.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7c6f55e9ef5d459b655a229e5dfe6cadfafcd4eb

Modified Files
--------------
src/backend/commands/dbcommands.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)