| Lists: | pgsql-hackers |
|---|
| From: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | review printing ecpg program version |
| Date: | 2018-09-12 06:52:54 |
| Message-ID: | 3747cabe-f3dc-6bf7-ad6a-79bc6616109c@postgresql.kr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
hi,
I found a little problem about printing ecpg version.
unlike PostgreSQL ver.11 other programs, ecpg version string has only
version number.
$ ./ecpg --version
ecpg 11beta3
$ ./psql --version
psql (PostgreSQL) 11beta3
$ ./pg_dump --version
pg_dump (PostgreSQL) 11beta3
I hope PostgreSQL product name be included in ecpg version string,
It will clarify version between other products (ex. EnterpriseDB
Postgres, GP, ...)
Regards, Ioseph.
| From: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review printing ecpg program version |
| Date: | 2018-09-12 06:55:56 |
| Message-ID: | 8c098a59-6afc-a39b-a653-4811cb2c5c56@postgresql.kr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
check please pg_config --version too.
2018년 09월 12일 15:52에 Ioseph Kim 이(가) 쓴 글:
> hi,
>
> I found a little problem about printing ecpg version.
>
> unlike PostgreSQL ver.11 other programs, ecpg version string has only
> version number.
>
>
> $ ./ecpg --version
> ecpg 11beta3
>
> $ ./psql --version
> psql (PostgreSQL) 11beta3
>
> $ ./pg_dump --version
> pg_dump (PostgreSQL) 11beta3
>
> I hope PostgreSQL product name be included in ecpg version string,
>
> It will clarify version between other products (ex. EnterpriseDB
> Postgres, GP, ...)
>
>
> Regards, Ioseph.
>
>
>
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review printing ecpg program version |
| Date: | 2018-09-12 07:03:03 |
| Message-ID: | 20180912070303.GJ25160@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:
> check please pg_config --version too.
Well, one problem with that is that you would break a ton of stuff which
parse this version string automatically. pg_config --version is used by
many extensions to guess which version of Postgres is being worked on.
--
Michael
| From: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review printing ecpg program version |
| Date: | 2018-09-12 08:32:24 |
| Message-ID: | 726f1f1a-bdba-85f2-d26a-ce4317b8cccf@postgresql.kr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
ok, in case pg_config, ignore this, but It should be review in case ecpg.
2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글:
> On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:
>> check please pg_config --version too.
> Well, one problem with that is that you would break a ton of stuff which
> parse this version string automatically. pg_config --version is used by
> many extensions to guess which version of Postgres is being worked on.
> --
> Michael
| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review printing ecpg program version |
| Date: | 2018-09-12 12:41:11 |
| Message-ID: | f8521447-2cb0-10f0-eab0-4e9ee9dbe33f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/09/2018 10:32, Ioseph Kim wrote:
> ok, in case pg_config, ignore this, but It should be review in case ecpg.
fixed
> 2018년 09월 12일 16:03에 Michael Paquier 이(가) 쓴 글:
>> On Wed, Sep 12, 2018 at 03:55:56PM +0900, Ioseph Kim wrote:
>>> check please pg_config --version too.
>> Well, one problem with that is that you would break a ton of stuff which
>> parse this version string automatically. pg_config --version is used by
>> many extensions to guess which version of Postgres is being worked on.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Ioseph Kim <pgsql-kr(at)postgresql(dot)kr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review printing ecpg program version |
| Date: | 2018-09-13 03:38:37 |
| Message-ID: | 20180913033837.GE3578@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Sep 12, 2018 at 02:41:11PM +0200, Peter Eisentraut wrote:
> On 12/09/2018 10:32, Ioseph Kim wrote:
>> ok, in case pg_config, ignore this, but It should be review in case ecpg.
>
> fixed
Thanks Peter for jumping in the ship. What you did looks correct to
me.
--
Michael