pgsql-server: Add missing null terminator to escaped string; clean up

Lists: pgsql-committers
From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql-server: Add missing null terminator to escaped string; clean up
Date: 2004-10-07 18:57:26
Message-ID: 20041007185726.C2946329EB2@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Log Message:
-----------
Add missing null terminator to escaped string; clean up unnecessarily
obscurantist coding conventions.

Modified Files:
--------------
pgsql-server/src/bin/initdb:
initdb.c (r1.58 -> r1.59)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/initdb/initdb.c.diff?r1=1.58&r2=1.59)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)svr1(dot)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Add missing null terminator to escaped
Date: 2004-10-07 19:02:31
Message-ID: 200410071902.i97J2Vn01299@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers


Thanks. Wonder why my testing worked? I guess xmalloc was giving me
zeroed memory.

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Add missing null terminator to escaped string; clean up unnecessarily
> obscurantist coding conventions.
>
> Modified Files:
> --------------
> pgsql-server/src/bin/initdb:
> initdb.c (r1.58 -> r1.59)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/initdb/initdb.c.diff?r1=1.58&r2=1.59)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Add missing null terminator to escaped
Date: 2004-10-07 19:07:18
Message-ID: 8610.1097176038@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Thanks. Wonder why my testing worked? I guess xmalloc was giving me
> zeroed memory.

One-shot programs like initdb are very likely to see all-zeroed memory,
since that's what the kernel gives you. It's only after you start
freeing things that you'll get nonzero areas from malloc ...

regards, tom lane