| Lists: | pgsql-committers |
|---|
| From: | momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql-server: Comment out unused variable. |
| Date: | 2004-10-04 15:09:28 |
| Message-ID: | 20041004150928.6FE93329FE8@svr1.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Log Message:
-----------
Comment out unused variable.
Modified Files:
--------------
pgsql-server/src/port:
crypt.c (r1.8 -> r1.9)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/port/crypt.c.diff?r1=1.8&r2=1.9)
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Bruce Momjian <momjian(at)svr1(dot)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql-server: Comment out unused variable. |
| Date: | 2004-10-04 23:47:06 |
| Message-ID: | 1096933626.9148.8.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
On Tue, 2004-10-05 at 01:09, Bruce Momjian wrote:
> Log Message:
> -----------
> Comment out unused variable.
If it is unused, it ought to be removed IMHO. Merely commenting out
unused code leads to bloat over time.
-Neil
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Bruce Momjian <momjian(at)svr1(dot)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql-server: Comment out unused variable. |
| Date: | 2004-10-05 02:02:37 |
| Message-ID: | 200410050202.i9522bM02538@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Neil Conway wrote:
> On Tue, 2004-10-05 at 01:09, Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Comment out unused variable.
>
> If it is unused, it ought to be removed IMHO. Merely commenting out
> unused code leads to bloat over time.
It was part of the original NetBSD code so I usually don't remove that
stuff so the code remains a similar as possible.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073