| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_resetwal: Corrections around -c option |
| Date: | 2023-10-10 07:05:54 |
| Message-ID: | E1qq6oT-000uM6-Tt@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_resetwal: Corrections around -c option
The present pg_resetwal code hardcodes the minimum value for -c as 2,
which is FrozenTransactionId, but it's not clear why that is allowed.
After some research, it was probably a mistake in the original patch.
Change it to FirstNormalTransactionId, which matches other xid-related
options in pg_resetwal.
Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://www.postgresql.org/message-id/flat/d09f0e91-8757-642b-1a92-da9a52f5589a%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e3679bc1c31add8fa29a9dedd10fe6c563efde79
Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-10-10 08:49:38 | pgsql: test_decoding: Remove unnecessary table in twophase test |
| Previous Message | Peter Eisentraut | 2023-10-10 05:56:13 | pgsql: Add const to values and nulls arguments |