pgsql: Fix possible crash in add_paths_to_append_rel()

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix possible crash in add_paths_to_append_rel()
Date: 2023-10-10 03:50:30
Message-ID: E1qq3lN-000stz-VC@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix possible crash in add_paths_to_append_rel()

While working on a8a968a82, I failed to consider that
cheapest_startup_path can be NULL when there is no non-parameterized
path in the pathlist. This is well documented in set_cheapest(), I just
failed to notice.

Here we adjust the code to just check if the RelOptInfo has a
cheapest_startup_path set before adding it to the startup_subpaths list.

Reported-by: Richard Guo
Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs49w3t03V69XhdCuw+GDwivny4uQUxrkVp6Gejaspt0wMQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fc4089f3c65a5f1b413a3299ba02b66a8e5e37d0

Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 11 +++++++----
src/test/regress/expected/union.out | 16 ++++++++++++++++
src/test/regress/sql/union.sql | 9 ++++++++-
3 files changed, 31 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-10-10 05:56:13 pgsql: Add const to values and nulls arguments
Previous Message David Rowley 2023-10-10 01:17:27 pgsql: Revert "Optimize various aggregate deserialization functions"