From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Ignore more environment variables in TAP tests |
Date: | 2021-06-03 02:52:43 |
Message-ID: | E1lodTP-0003tK-V9@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Ignore more environment variables in TAP tests
Various environment variables were not getting reset in the TAP tests,
which would cause failures depending on the tests or the environment
variables involved. For example, PGSSL{MAX,MIN}PROTOCOLVERSION could
cause failures in the SSL tests. Even worse, a junk value of
PGCLIENTENCODING makes a server startup fail. The list of variables
reset is adjusted in each stable branch depending on what is supported.
While on it, simplify a bit the code per a suggestion from Andrew
Dunstan, using a list of variables instead of doing single deletions.
Reviewed-by: Andrew Dunstan, Daniel Gustafsson
Discussion: https://postgr.es/m/YLbjjRpucIeZ78VQ@paquier.xyz
Backpatch-through: 9.6
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/36ac9f6af23039b334729b44a1751f1207f83f0e
Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++++++++++----------
1 file changed, 26 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2021-06-03 04:38:26 | pgsql: Standardize usages of appendStringInfo and appendPQExpBuffer |
Previous Message | Tom Lane | 2021-06-02 22:50:34 | pgsql: Re-allow custom GUC names that have more than two components. |