pgsql: Close psql processes gracefully in recovery tests

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Close psql processes gracefully in recovery tests
Date: 2021-03-04 18:24:17
Message-ID: E1lHse1-0001LB-4l@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Close psql processes gracefully in recovery tests

Under windows, psql processes need to be ended explicitly, or the TAP
tests hang. However, the recovery tests were doing this via
IPC::Run::kill_kill(), which causes other major problems on Windows.

We solve this by instead sending '\q' to psql so it quits of its own
accord, and then simply waiting for it. This means we can now run almost
all the recovery tests on all Windows platforms.

Discussion: https://postgr.es/m/20210301200715.tdjpuesfzebpffgn@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d3676a2e9f10a0972c6d6649235c1c7492cd6dea

Modified Files
--------------
src/test/recovery/t/011_crash_recovery.pl | 13 +++----------
src/test/recovery/t/021_row_visibility.pl | 9 ++++++---
2 files changed, 9 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-03-05 01:15:16 pgsql: Add support for PROVE_TESTS and PROVE_FLAGS in MSVC scripts
Previous Message Peter Eisentraut 2021-03-04 10:10:42 pgsql: pg_upgrade: Fix oversight in version checking