From: | Amit Kapila <akapila(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix assertion failure when updating full_page_writes for checkpo |
Date: | 2018-09-28 11:42:28 |
Message-ID: | E1g5rAC-0005pr-OI@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix assertion failure when updating full_page_writes for checkpointer.
When the checkpointer receives a SIGHUP signal to update its configuration,
it may need to update the shared memory for full_page_writes and need to
write a WAL record for it. Now, it is quite possible that the XLOG
machinery has not been initialized by that time and it will lead to
assertion failure while doing that. Fix is to allow the initialization of
the XLOG machinery outside critical section.
This bug has been introduced by the commit 2c03216d83 which added the XLOG
machinery initialization in RecoveryInProgress code path.
Reported-by: Dilip Kumar
Author: Dilip Kumar
Reviewed-by: Michael Paquier and Amit Kapila
Backpatch-through: 9.5
Discussion: https://postgr.es/m/CAFiTN-u4BA8KXcQUWDPNgaKAjDXC=C2whnzBM8TAcv=stckYUw@mail.gmail.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8256d7ae9ee3f8fec4bbe763b042b62d684e623f
Modified Files
--------------
src/backend/access/transam/xlog.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Christoph Berg | 2018-09-28 11:58:31 | Re: pgsql: Build src/port files as a library with -fPIC, and use that in li |
Previous Message | Andres Freund | 2018-09-28 05:02:47 | pgsql: Correct overflow handling in pgbench. |