pgsql: Rearrange makefile rules for running Gen_fmgrtab.pl.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rearrange makefile rules for running Gen_fmgrtab.pl.
Date: 2018-05-03 22:06:51
Message-ID: E1fEMNH-0000pz-9k@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rearrange makefile rules for running Gen_fmgrtab.pl.

Make these rules look more like the ones associated with genbki.pl,
to wit:

* Use a stamp file to record when we last ran the script, instead of
relying on the timestamps of the individual output files.

* Take the knowledge out of backend/Makefile and put it in utils/Makefile
where it belongs. I moved down the handling of errcodes.h and probes.h
too, although those continue to be built by separate processes.

In itself, this is just much-needed cleanup with little practical effect.
However, by decoupling these makefile rules from the timestamps of the
generated header files, we open the door to not advancing those timestamps
unnecessarily, which will be taken advantage of by the next commit.

msvc/Solution.pm should be taught to do things similarly, but I'll leave
that for another commit.

Discussion: https://postgr.es/m/16925.1525376229@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9bf28f96c7eb0c3630ef034679c426c2ee289aca

Modified Files
--------------
src/backend/Makefile | 49 ++++++++------------------------------------
src/backend/catalog/Makefile | 5 ++++-
src/backend/utils/.gitignore | 1 +
src/backend/utils/Makefile | 44 ++++++++++++++++++++++++++++-----------
src/include/Makefile | 2 +-
src/include/utils/.gitignore | 1 +
6 files changed, 48 insertions(+), 54 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-05-03 22:47:47 pgsql: Blindly try to fix MSVC build's use of genbki.pl and Gen_fmgrtab
Previous Message Peter Eisentraut 2018-05-03 17:13:20 pgsql: Tweak tests to support Python 3.7