pgsql: Replace enum InhOption with simple boolean.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Replace enum InhOption with simple boolean.
Date: 2016-12-23 18:35:43
Message-ID: E1cKUgx-0002U1-GL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Replace enum InhOption with simple boolean.

Now that it has only INH_NO and INH_YES values, it's just weird that
it's not a plain bool, so make it that way.

Also rename RangeVar.inhOpt to "inh", to be like RangeTblEntry.inh.
My recollection is that we gave it a different name specifically because
it had a different representation than the derived bool value, but it
no longer does. And this is a good forcing function to be sure we
catch any places that are affected by the change.

Bump catversion because of possible effect on stored RangeVar nodes.
I'm not exactly convinced that we ever store RangeVar on disk, but
we have a readfuncs function for it, so be cautious. (If we do do so,
then commit e13486eba was in error not to bump catversion.)

Follow-on to commit e13486eba.

Discussion: http://postgr.es/m/CA+TgmoYe+EG7LdYX6pkcNxr4ygkP4+A=jm9o-CPXyOvRiCNwaQ@mail.gmail.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fe591f8bf68db9bf81f278acce6239ee68cd4ed6

Modified Files
--------------
src/backend/commands/lockcmds.c | 2 +-
src/backend/commands/tablecmds.c | 11 +++++------
src/backend/nodes/copyfuncs.c | 3 +--
src/backend/nodes/equalfuncs.c | 2 +-
src/backend/nodes/makefuncs.c | 2 +-
src/backend/nodes/outfuncs.c | 2 +-
src/backend/nodes/readfuncs.c | 2 +-
src/backend/parser/analyze.c | 4 ++--
src/backend/parser/gram.y | 10 +++++-----
src/backend/parser/parse_clause.c | 3 +--
src/include/catalog/catversion.h | 2 +-
src/include/nodes/primnodes.h | 10 ++--------
12 files changed, 22 insertions(+), 31 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2016-12-24 02:02:02 pgsql: Fix tab completion in psql for ALTER DEFAULT PRIVILEGES
Previous Message Peter Eisentraut 2016-12-23 18:19:03 pgsql: Remove unnecessary casts of makeNode() result