| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Remove wrong CloseHandle() call. |
| Date: | 2016-12-03 20:55:05 |
| Message-ID: | E1cDHKr-0003hs-If@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove wrong CloseHandle() call.
In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle. GetModuleHandle() does not so direct. We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative. Back-patch to 9.2 (all
supported versions).
Christian Ullrich, reviewed by Michael Paquier.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/b37da1e8a0e46ae12415fafd3ea441fc3546cf2f
Modified Files
--------------
src/port/win32env.c | 1 -
1 file changed, 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2016-12-03 20:58:45 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Previous Message | Tom Lane | 2016-12-03 16:43:02 | Re: [COMMITTERS] pgsql: Add max_parallel_workers GUC. |