Allow _h_indexbuild() to be interrupted.

When we are building a hash index that is large enough to need
pre-sorting (larger than either maintenance_work_mem or NBuffers),
the initial sorting phase is interruptible, but the insertion
phase wasn't.  Add the missing CHECK_FOR_INTERRUPTS().

Per bug #18616 from Alexander Lakhin.  Back-patch to all
supported branches.

Pavel Borisov

Discussion: https://postgr.es/m/18616-acbb9e5caf41e964@postgresql.org

diff --git a/src/backend/access/hash/hashsort.c b/src/backend/access/hash/hashsort.c
index aa61e39f26acba4b9195ae1657d4ac2fd3812580..bd59ff86f554fc03e75ceb7bf24774f92fc68c0a 100644 (file)
--- a/src/backend/access/hash/hashsort.c
+++ b/src/backend/access/hash/hashsort.c
@@ -146,6 +146,9 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)
 
        _hash_doinsert(hspool->index, itup, heapRel);
 
+       /* allow insertion phase to be interrupted, and track progress */
+       CHECK_FOR_INTERRUPTS();
+
        pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE,
                                     ++tups_done);
    }