Remove unnecessary dependencies to wal_level=logical in TAP tests
authorMichael Paquier <michael@paquier.xyz>
Fri, 20 Oct 2023 01:09:27 +0000 (10:09 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 20 Oct 2023 01:09:27 +0000 (10:09 +0900)
A couple of TAP tests make use of wal_level=logical for nodes that do
not need to do any kind of logical decoding operations, like
subscription nodes on which changes are only applied.  This can be
confusing when reading these tests as setup examples, so let's remove
this configuration where not required (contrary to two-way logical
replication and similar more complex cases).  This simplifies the tests
a bit, making them slightly cheaper with less WAL generated overall.

Author: Hayato Kuroda
Discussion: https://postgr.es/m/TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com

32 files changed:
src/test/recovery/t/035_standby_logical_decoding.pl
src/test/recovery/t/038_save_logical_slots_shutdown.pl
src/test/subscription/t/001_rep_changes.pl
src/test/subscription/t/002_types.pl
src/test/subscription/t/003_constraints.pl
src/test/subscription/t/004_sync.pl
src/test/subscription/t/005_encoding.pl
src/test/subscription/t/006_rewrite.pl
src/test/subscription/t/007_ddl.pl
src/test/subscription/t/008_diff_schema.pl
src/test/subscription/t/009_matviews.pl
src/test/subscription/t/010_truncate.pl
src/test/subscription/t/011_generated.pl
src/test/subscription/t/012_collation.pl
src/test/subscription/t/013_partition.pl
src/test/subscription/t/014_binary.pl
src/test/subscription/t/015_stream.pl
src/test/subscription/t/016_stream_subxact.pl
src/test/subscription/t/017_stream_ddl.pl
src/test/subscription/t/018_stream_subxact_abort.pl
src/test/subscription/t/019_stream_subxact_ddl_abort.pl
src/test/subscription/t/020_messages.pl
src/test/subscription/t/021_twophase.pl
src/test/subscription/t/022_twophase_cascade.pl
src/test/subscription/t/023_twophase_stream.pl
src/test/subscription/t/024_add_drop_pub.pl
src/test/subscription/t/025_rep_changes_for_schema.pl
src/test/subscription/t/026_stats.pl
src/test/subscription/t/028_row_filter.pl
src/test/subscription/t/031_column_list.pl
src/test/subscription/t/032_subscribe_use_index.pl
src/test/subscription/t/100_bugs.pl

index 480e6d6caa5e8dd30e6e09bb8281a2ae6ae4a332..9c34c0d36cbfc1f018f3c546cb991f51add1b598 100644 (file)
@@ -293,7 +293,7 @@ $node_primary->wait_for_replay_catchup($node_standby);
 #######################
 # Initialize subscriber node
 #######################
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my %psql_subscriber = (
index de198295607a729a54d9cc0ba8d020277d345c85..52ec4e88200bc2b119c07f44cd964bde16dd0548 100644 (file)
@@ -53,7 +53,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('sub');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create tables
index 0a399cdb82b92b22ea26bde9c932874d02708929..87d44f634f5c5157e58761e4eab5c3d58c673298 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 6b5853b80b6678e06069ac587579d55ac4fe9045..40155ad5633a888acd3adcda0d31709f05f94a7e 100644 (file)
@@ -16,7 +16,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 6e902360cc6bc6a13087704cb8217716b25fd800..6e3591d486b5ffcb816dc447c05a7b3debd0dac8 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Setup structure on publisher
index ee07d28b37267d9ee1ce33d536f88ec55e8c2f08..11269708aa254d3a9e67cf9baca6fc639ad7db8d 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->append_conf('postgresql.conf',
    "wal_retrieve_retry_interval = 1ms");
 $node_subscriber->start;
index 2f0bf7730b96ac069414878c6c04e2806e4557d7..c9cece48c451491c52d01522e84edc10c364d0c0 100644 (file)
@@ -15,9 +15,7 @@ $node_publisher->init(
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(
-   allows_streaming => 'logical',
-   extra => [ '--locale=C', '--encoding=LATIN1' ]);
+$node_subscriber->init(extra => [ '--locale=C', '--encoding=LATIN1' ]);
 $node_subscriber->start;
 
 my $ddl = "CREATE TABLE test1 (a int, b text);";
index 8bc7e872d9b24f0c043498829dce599eff7a1985..62a1bdcd15213ecac16db894db840c38da7e537d 100644 (file)
@@ -13,7 +13,7 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $ddl = "CREATE TABLE test1 (a int, b text);";
index cbdb5b66e469fcc8be717f325ba1ebb176a29ad9..02e9dd61d53b830d2b76f9a2a288752f15812ce9 100644 (file)
@@ -13,7 +13,7 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $ddl = "CREATE TABLE test1 (a int, b text);";
index c6e41b65b9fc6d456a6b5b55b743be97f4b307bb..ed676b73e56b48cebc88691e23a2060f2d9beae8 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 38080b431320646505838b64ef9eca79ef685635..798aad53c7381a65831aea66f84655cc6d5b9782 100644 (file)
@@ -13,7 +13,7 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
index a5b64453924bb19b071217044ef754c262810922..9eeb518b5281cfe06aed908c03e650969a96182f 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->append_conf('postgresql.conf',
    qq(max_logical_replication_workers = 6));
 $node_subscriber->start;
index 7711be295a0d59685cc9649a885f3b8f9fea815f..4f8518cf351de52937fdbc74a5e755d55f6693a8 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
index 823550a31b53060d30b5be2165c91dfdd223f8a7..dd66424be8c543768cc106976b26c04064658777 100644 (file)
@@ -21,9 +21,7 @@ $node_publisher->init(
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(
-   allows_streaming => 'logical',
-   extra => [ '--locale=C', '--encoding=UTF8' ]);
+$node_subscriber->init(extra => [ '--locale=C', '--encoding=UTF8' ]);
 $node_subscriber->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
index 275fb3b52572196882f153a5d7a5b7a7c86a378e..0f1a34235d0a1bf3aedb5159e36042c8fe2862d6 100644 (file)
@@ -15,11 +15,11 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber1 = PostgreSQL::Test::Cluster->new('subscriber1');
-$node_subscriber1->init(allows_streaming => 'logical');
+$node_subscriber1->init;
 $node_subscriber1->start;
 
 my $node_subscriber2 = PostgreSQL::Test::Cluster->new('subscriber2');
-$node_subscriber2->init(allows_streaming => 'logical');
+$node_subscriber2->init;
 $node_subscriber2->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
index e5ce849c191aafe3bfbe76b3357b2a3d189aec5f..6abc899bd966fae1c6a61472013c65f0825420d6 100644 (file)
@@ -16,7 +16,7 @@ $node_publisher->start;
 
 # Create and initialize subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create tables on both sides of the replication
index 603d00f9e78f60c4d69403bb12e5707e4ebc04ef..986e879968c658110c87d9438ebe7388cfd7b3e6 100644 (file)
@@ -131,7 +131,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 9a2f06f272080b34bb17ea94c9361258706c2a74..561855cb42cc8004f8a8c11561b2004ea007c50b 100644 (file)
@@ -84,7 +84,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index d00ede44ed133a8a84d3c5ab69abf60e4eafb15e..2fd4ede4027f8e81c8e57aa596a74ca866172ad4 100644 (file)
@@ -20,7 +20,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 201138882c383393656808206fb44998e369845a..e115216e7557e50f3d76cf29f843704f61123bcd 100644 (file)
@@ -135,7 +135,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 1ad7ace84a09e2a9d121f4088cbf718f15961b23..cd26eee05a2eb68143f6cbd2d89f708a5413ca07 100644 (file)
@@ -21,7 +21,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 826d39cd89a564eee087b110669243311cd79a16..6f31fe4d6f71d937df218821176136277c85b29e 100644 (file)
@@ -16,7 +16,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create some preexisting content on publisher
index 8ce4cfc983ca40559123bce966fac8891556578b..9bcf46c7b359e8f1a5fc10d7d51d196017519344 100644 (file)
@@ -21,7 +21,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->append_conf('postgresql.conf',
    qq(max_prepared_transactions = 10));
 $node_subscriber->start;
index b37ed95c9e24b5f9d77db8b38e2b0cb575c1f7a3..75b1a62a743825c8bb2d827dbea3297dd0366006 100644 (file)
@@ -39,7 +39,7 @@ logical_decoding_work_mem = 64kB
 $node_B->start;
 # node_C
 my $node_C = PostgreSQL::Test::Cluster->new('node_C');
-$node_C->init(allows_streaming => 'logical');
+$node_C->init;
 $node_C->append_conf(
    'postgresql.conf', qq(
 max_prepared_transactions = 10
index be9f2aab282e7861160cc9d225b18d033c5379a3..22948e6424841e929e520f44458e70ab1bbd5711 100644 (file)
@@ -307,7 +307,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->append_conf(
    'postgresql.conf', qq(
 max_prepared_transactions = 10
index 8614b1b5b34d47aeeaf0c2e008f6830ee3acc9f3..cdb14a919a8bfedac7d9776bd991944ae908fd00 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Create table on publisher
index 8543f52710ccd897dbda2c6d99fa57e5f4e53c80..97405cd8d555b1f0f76255595654a74f80d392bf 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 # Test replication with publications created using FOR TABLES IN SCHEMA
index a033588008fcae2363dbe90f0bab8f45b9e87d9a..f31b25b4afa75d92b4c318bc8be3cd6109e5ed3c 100644 (file)
@@ -15,7 +15,7 @@ $node_publisher->start;
 
 # Create subscriber node.
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 
index aec483f785fee4cc5417fde4a02f81c09023ebfb..1510149f97ba89a34a04f402321963f46b675fdf 100644 (file)
@@ -14,7 +14,7 @@ $node_publisher->start;
 
 # create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
index dbff806040255bdfde184a6f260502308e3af77c..7bf83e01f463ebe70f210c5a0ba50d375196b3b5 100644 (file)
@@ -14,7 +14,7 @@ $node_publisher->start;
 
 # create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->append_conf('postgresql.conf',
    qq(max_logical_replication_workers = 6));
 $node_subscriber->start;
index 880ef2d57a64b4051fdf3923a89b6706408baf76..d1f65d05e5eb5c10a3706ef2a6129309aa90765d 100644 (file)
@@ -14,7 +14,7 @@ $node_publisher->start;
 
 # create subscriber node
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
index 4fabc4416831e71cca007a219e8d192013e72b06..7e5221afff7ef1bf879c4a4ec5a07b9408e8362c 100644 (file)
@@ -24,7 +24,7 @@ $node_publisher->init(allows_streaming => 'logical');
 $node_publisher->start;
 
 my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
-$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->init;
 $node_subscriber->start;
 
 my $publisher_connstr = $node_publisher->connstr . ' dbname=postgres';
@@ -175,7 +175,7 @@ $node_pub_sub->init(allows_streaming => 'logical');
 $node_pub_sub->start;
 
 my $node_sub = PostgreSQL::Test::Cluster->new('testsubscriber1');
-$node_sub->init(allows_streaming => 'logical');
+$node_sub->init;
 $node_sub->start;
 
 # Create the tables in all nodes.