Fix thinko in in_range_float4_float8.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 24 Feb 2018 19:46:37 +0000 (14:46 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 24 Feb 2018 19:46:37 +0000 (14:46 -0500)
I forgot the coding rule for correct use of Float8GetDatumFast.
Per buildfarm.

src/backend/utils/adt/float.c

index 4f718c3eff122cb64666b4885ecb043ff02454c6..aadb92de6634eaefec6a31e10eac56888870f0ce 100644 (file)
@@ -1259,9 +1259,12 @@ Datum
 in_range_float4_float8(PG_FUNCTION_ARGS)
 {
    /* Doesn't seem worth duplicating code for, so just invoke float8_float8 */
+   float8      val = (float8) PG_GETARG_FLOAT4(0);
+   float8      base = (float8) PG_GETARG_FLOAT4(1);
+
    return DirectFunctionCall5(in_range_float8_float8,
-                              Float8GetDatumFast((float8) PG_GETARG_FLOAT4(0)),
-                              Float8GetDatumFast((float8) PG_GETARG_FLOAT4(1)),
+                              Float8GetDatumFast(val),
+                              Float8GetDatumFast(base),
                               PG_GETARG_DATUM(2),
                               PG_GETARG_DATUM(3),
                               PG_GETARG_DATUM(4));