From 1db4e5a4eeec0c5e240628923daf0e0a666f8c04 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Wed, 6 Apr 2022 21:29:46 -0700 Subject: [PATCH] pgstat: rename STATS_COLLECTOR GUC group to STATS_CUMULATIVE. Reviewed-By: Kyotaro Horiguchi Author: Andres Freund Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de --- src/backend/utils/misc/guc.c | 18 +++++++++--------- src/backend/utils/misc/postgresql.conf.sample | 2 +- src/include/utils/guc_tables.h | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 719f8cb177a..998b8a94c45 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -810,8 +810,8 @@ const char *const config_group_names[] = gettext_noop("Reporting and Logging / Process Title"), /* STATS_MONITORING */ gettext_noop("Statistics / Monitoring"), - /* STATS_COLLECTOR */ - gettext_noop("Statistics / Query and Index Statistics Collector"), + /* STATS_CUMULATIVE */ + gettext_noop("Statistics / Cumulative Query and Index Statistics"), /* AUTOVACUUM */ gettext_noop("Autovacuum"), /* CLIENT_CONN_STATEMENT */ @@ -1548,7 +1548,7 @@ static struct config_bool ConfigureNamesBool[] = #endif { - {"track_activities", PGC_SUSET, STATS_COLLECTOR, + {"track_activities", PGC_SUSET, STATS_CUMULATIVE, gettext_noop("Collects information about executing commands."), gettext_noop("Enables the collection of information on the currently " "executing command of each session, along with " @@ -1559,7 +1559,7 @@ static struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - {"track_counts", PGC_SUSET, STATS_COLLECTOR, + {"track_counts", PGC_SUSET, STATS_CUMULATIVE, gettext_noop("Collects statistics on database activity."), NULL }, @@ -1568,7 +1568,7 @@ static struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - {"track_io_timing", PGC_SUSET, STATS_COLLECTOR, + {"track_io_timing", PGC_SUSET, STATS_CUMULATIVE, gettext_noop("Collects timing statistics for database I/O activity."), NULL }, @@ -1577,7 +1577,7 @@ static struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - {"track_wal_io_timing", PGC_SUSET, STATS_COLLECTOR, + {"track_wal_io_timing", PGC_SUSET, STATS_CUMULATIVE, gettext_noop("Collects timing statistics for WAL I/O activity."), NULL }, @@ -3539,7 +3539,7 @@ static struct config_int ConfigureNamesInt[] = }, { - {"track_activity_query_size", PGC_POSTMASTER, STATS_COLLECTOR, + {"track_activity_query_size", PGC_POSTMASTER, STATS_CUMULATIVE, gettext_noop("Sets the size reserved for pg_stat_activity.query, in bytes."), NULL, GUC_UNIT_BYTE @@ -4907,7 +4907,7 @@ static struct config_enum ConfigureNamesEnum[] = }, { - {"track_functions", PGC_SUSET, STATS_COLLECTOR, + {"track_functions", PGC_SUSET, STATS_CUMULATIVE, gettext_noop("Collects function-level statistics on database activity."), NULL }, @@ -4918,7 +4918,7 @@ static struct config_enum ConfigureNamesEnum[] = { - {"stats_fetch_consistency", PGC_USERSET, STATS_COLLECTOR, + {"stats_fetch_consistency", PGC_USERSET, STATS_CUMULATIVE, gettext_noop("Sets the consistency of accesses to statistics data"), NULL }, diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index 64e5d11cd69..e75b7d63ea3 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -605,7 +605,7 @@ # STATISTICS #------------------------------------------------------------------------------ -# - Query and Index Statistics Collector - +# - Cumulative Query and Index Statistics - #track_activities = on #track_activity_query_size = 1024 # (change requires restart) diff --git a/src/include/utils/guc_tables.h b/src/include/utils/guc_tables.h index f7e54a87b7b..1c5b3930a97 100644 --- a/src/include/utils/guc_tables.h +++ b/src/include/utils/guc_tables.h @@ -82,7 +82,7 @@ enum config_group LOGGING_WHAT, PROCESS_TITLE, STATS_MONITORING, - STATS_COLLECTOR, + STATS_CUMULATIVE, AUTOVACUUM, CLIENT_CONN_STATEMENT, CLIENT_CONN_LOCALE, -- 2.39.5