Check slot->restart_lsn validity in a few more places
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 29 Apr 2020 00:39:04 +0000 (20:39 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 29 Apr 2020 00:39:04 +0000 (20:39 -0400)
commitd0abe78d84274cc203f3d117b8006dc2164ca31a
tree34df7310c6f1c9ca08b2df1aceb414d1255ed65c
parent52b164c5a00095a34685e66bf64b009578b9cfda
Check slot->restart_lsn validity in a few more places

Lack of these checks could cause visible misbehavior, including
assertion failures.  This was missed in commit c6550776394e, whereby
restart_lsn becomes invalid when the size limit is exceeded.

Also reword some existing error messages, and add errdetail(), so that
the reported errors all match in spirit.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20200408.093710.447591748588426656.horikyota.ntt@gmail.com
contrib/test_decoding/expected/slot.out
src/backend/replication/logical/logicalfuncs.c
src/backend/replication/slotfuncs.c
src/backend/replication/walsender.c