Avoid memcpy() with same source and destination during relmapper init.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Dec 2020 20:46:44 +0000 (15:46 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Dec 2020 20:46:44 +0000 (15:46 -0500)
commit53d4f5fef04653fc495ae385a9c2f78c77e5c7d9
tree9f482b546fd9ee18acf39932b3ada3d86d8a23fa
parent2e0fedf0362cc964c4dae42258455b6391051e70
Avoid memcpy() with same source and destination during relmapper init.

A narrow reading of the C standard says that memcpy(x,x,n) is undefined,
although it's hard to envision an implementation that would really
misbehave.  However, analysis tools such as valgrind might whine about
this; accordingly, let's band-aid relmapper.c to not do it.

See also 5b630501ed3f4e8a8aad7b48ea0, and other similar fixes.
Apparently, none of those folk tried valgrinding initdb?  This has been
like this for long enough that I'm surprised it hasn't been reported
before.

Back-patch, just in case anybody wants to use a back branch on a platform
that complains about this; we back-patched those earlier fixes too.

Discussion: https://postgr.es/m/161790.1608310142@sss.pgh.pa.us
src/backend/utils/cache/relmapper.c