Fix thinko in commit 2bd9e412f92bc6a68f3e8bcb18e04955cc35001d.

Obviously, every translation unit should not be declaring this
separately.  It needs to be PGDLLIMPORT as well, to avoid breaking
third-party code that uses any of the functions that the commit
mentioned above changed to macros.

diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index dcbb704c6a59b3abc65e197e5c6cbe38f5c7ec40..74161970ab51362c46c9f2303343ded8e57d9ab9 100644 (file)
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -105,6 +105,8 @@ char           *Unix_socket_group;
 /* Where the Unix socket files are (list of palloc'd strings) */
 static List *sock_paths = NIL;
 
+PQcommMethods *PqCommMethods;
+
 
 /*
  * Buffers for low-level I/O.

diff --git a/src/include/libpq/libpq.h b/src/include/libpq/libpq.h
index 409f3d7786e27d88265ea03da98594615356c170..2a61a9e143d33fc05a4bdd9ec6829ab1e341b102 100644 (file)
--- a/src/include/libpq/libpq.h
+++ b/src/include/libpq/libpq.h
@@ -49,7 +49,7 @@ typedef struct
        void (*endcopyout)(bool errorAbort);
 } PQcommMethods;
 
-PQcommMethods *PqCommMethods;
+extern PGDLLIMPORT PQcommMethods *PqCommMethods;
 
 #define pq_comm_reset()        (PqCommMethods->comm_reset())
 #define pq_flush() (PqCommMethods->flush())