pg_upgrade: no need to check for matching float8_pass_by_value

Report by Noah Misch

diff --git a/src/bin/pg_upgrade/controldata.c b/src/bin/pg_upgrade/controldata.c
index 0608b644796d837daae39c8cabe788676b540451..142e623c0919851acde43401235b9a3ec6c296f7 100644 (file)
--- a/src/bin/pg_upgrade/controldata.c
+++ b/src/bin/pg_upgrade/controldata.c
@@ -564,8 +564,7 @@ check_control_data(ControlData *oldctrl,
        if (oldctrl->date_is_int != newctrl->date_is_int)
                pg_fatal("old and new pg_controldata date/time storage types do not match\n");
 
-       if (oldctrl->float8_pass_by_value != newctrl->float8_pass_by_value)
-               pg_fatal("old and new pg_controldata float8 argument passing methods do not match\n");
+       /* float8_pass_by_value does not need to match */
 
        /*
         * We might eventually allow upgrades from checksum to no-checksum