Add test_pg_dump to @contrib_excludes

The test_pg_dump extension doesn't have a C component, so we need
to exclude it from the MSVC build system trying to figure out how
to build it.

Also add a "MODULES" line to the Makefile, as test_extensions has.
Might not be necessary, but seems good to keep things consistent.

Lastly, remove the 'installcheck' line from test_pg_dump, as that
was causing redefinition errors, at least on my box.  This also
makes test_pg_dump consistent with how commit_ts is set up.

diff --git a/src/test/modules/test_pg_dump/Makefile b/src/test/modules/test_pg_dump/Makefile
index e6adbb82b42eb4b765375fbbf70d61ff36bdf28c..08d8903e721fbf66e1bddde5093e2ff454bc0fbf 100644 (file)
--- a/src/test/modules/test_pg_dump/Makefile
+++ b/src/test/modules/test_pg_dump/Makefile
@@ -1,5 +1,6 @@
 # src/test/modules/test_rls_hooks/Makefile
 
+MODULE = test_pg_dump
 PGFILEDESC = "test_pg_dump - Test pg_dump with an extension"
 
 EXTENSION = test_pg_dump
@@ -12,9 +13,6 @@ check: prove-check
 prove-check:
        $(prove_check)
 
-installcheck:
-       $(prove_installcheck)
-
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)

diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
index 3c5092ff9a68a57b700c698c2c08e9fb36b336e0..e7268cb2ed3ff2f288b50a85eaad6098a38e3af7 100644 (file)
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -43,7 +43,7 @@ my $contrib_extrasource = {
 my @contrib_excludes = (
        'commit_ts',       'hstore_plperl',    'hstore_plpython', 'intagg',
        'ltree_plpython',  'pgcrypto',         'sepgsql',         'brin',
-       'test_extensions', 'snapshot_too_old');
+       'test_extensions', 'test_pg_dump', 'snapshot_too_old');
 
 # Set of variables for frontend modules
 my $frontend_defines = { 'initdb' => 'FRONTEND' };