Recent changes got the sense of the notnull bit backwards in the 2.0

protocol output routines.  Mea culpa :-(.  Per report from Kris Jurka.

diff --git a/src/backend/access/common/printtup.c b/src/backend/access/common/printtup.c
index e78dc19a03fddf18d624449f4e38de158a5009d1..d9dc2ae17fcc54936b489a64279a11a0729ce4af 100644 (file)
--- a/src/backend/access/common/printtup.c
+++ b/src/backend/access/common/printtup.c
@@ -9,7 +9,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/access/common/printtup.c,v 1.88 2005/04/06 16:34:04 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/access/common/printtup.c,v 1.89 2005/04/23 17:45:35 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -402,7 +402,7 @@ printtup_20(TupleTableSlot *slot, DestReceiver *self)
        k = 1 << 7;
        for (i = 0; i < natts; ++i)
        {
-               if (slot->tts_isnull[i])
+               if (!slot->tts_isnull[i])
                        j |= k;                         /* set bit if not null */
                k >>= 1;
                if (k == 0)                             /* end of byte? */
@@ -610,7 +610,7 @@ printtup_internal_20(TupleTableSlot *slot, DestReceiver *self)
        k = 1 << 7;
        for (i = 0; i < natts; ++i)
        {
-               if (slot->tts_isnull[i])
+               if (!slot->tts_isnull[i])
                        j |= k;                         /* set bit if not null */
                k >>= 1;
                if (k == 0)                             /* end of byte? */