Fix cache reference leak in contrib/sepgsql.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 16 Apr 2020 18:45:54 +0000 (14:45 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 16 Apr 2020 18:45:54 +0000 (14:45 -0400)
commitfc576b7c4f3a5f045d443fc771d9e0f54b33e72b
treeb657c676c1e90c2b6f379bb9351c98aa4f3d6f4b
parent24d2d38b1eb86c0b410ad0f07f66566a83c6f05c
Fix cache reference leak in contrib/sepgsql.

fixup_whole_row_references() did the wrong thing with a dropped column,
resulting in a commit-time warning about a cache reference leak.

I (tgl) added a test case exercising this, but back-patched the test
only as far as v10; the patch didn't apply cleanly to 9.6 and it
didn't seem worth the trouble to adapt it.  The bug is pretty old
though, so apply the code change all the way back.

Michael Luo, with cosmetic improvements by me

Discussion: https://postgr.es/m/BYAPR08MB5606D1453D7F50E2AF4D2FD29AD80@BYAPR08MB5606.namprd08.prod.outlook.com
contrib/sepgsql/dml.c
contrib/sepgsql/expected/dml.out
contrib/sepgsql/sql/dml.sql