Fix cases of discarding result from list API functions
authorPeter Eisentraut <peter@eisentraut.org>
Sat, 17 Oct 2020 06:38:39 +0000 (08:38 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 11 Nov 2020 07:03:51 +0000 (08:03 +0100)
commitc77f6f50e4187bed38d1d36ae16b0c248e286d15
treeaec90088f2a4f1c445a0b4540b7ec8a0fa4e6fec
parentec29427ce2a451e7fef7a22de6db8147d8a80994
Fix cases of discarding result from list API functions

Two cases violated list APIs by throwing away the return value.  While
the code was technically correct, it relied on internal knowledge of
the list implementation, and the code wasn't really gaining anything
that way.  It is planned to make this a compiler warning in the
future, so just fix these cases by assigning the return value
properly.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://www.postgresql.org/message-id/flat/e3753562-99cd-b65f-5aca-687dfd1ec2fc@2ndquadrant.com
src/backend/commands/lockcmds.c
src/backend/parser/analyze.c