Fix record length computation in pg_waldump/xlogdump.
authorAndres Freund <andres@anarazel.de>
Mon, 5 Jun 2017 22:56:58 +0000 (15:56 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 5 Jun 2017 23:10:07 +0000 (16:10 -0700)
commitc25ed20067d21a97242a023031fcdcc232d6945c
treec2aac25ce46b007866ae10e6df8e8caed65f25e2
parent3e60c6f72328a9ad14d8a087411cd394752c5b23
Fix record length computation in pg_waldump/xlogdump.

The current method of computing the record length (excluding the
lenght of full-page images) has been wrong since the WAL format has
been revamped in 2c03216d831160bedd72d45f712601b6f7d03f1c.  Only the
main record's length was counted, but that can be significantly too
little if there's data associated with further blocks.

Fix by computing the record length as total_lenght - fpi_length.

Reported-By: Chen Huajun
Bug: #14687
Reviewed-By: Heikki Linnakangas
Discussion: https://postgr.es/m/20170603165939.1436.58887@wrigleys.postgresql.org
Backpatch: 9.5-
src/bin/pg_waldump/pg_waldump.c