Fix misuse of table_index_fetch_tuple_check().
authorPeter Geoghegan <pg@bowt.ie>
Thu, 25 Jun 2020 17:55:28 +0000 (10:55 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Thu, 25 Jun 2020 17:55:28 +0000 (10:55 -0700)
commit10f1ab2cb8bea3c6741a78f6dc19a5c91c0a34e1
tree37a1a8de2bd0d98a2a76341fb5d8a6426d757f0f
parent463b808e757928f053490dd397af77a80b4e7baa
Fix misuse of table_index_fetch_tuple_check().

Commit 0d861bbb, which added deduplication to nbtree, had
_bt_check_unique() pass a TID to table_index_fetch_tuple_check() that
isn't safe to mutate.  table_index_fetch_tuple_check()'s tid argument is
modified when the TID in question is not the latest visible tuple in a
hot chain, though this wasn't documented.

To fix, go back to using a local copy of the TID in _bt_check_unique(),
and update comments above table_index_fetch_tuple_check().

Backpatch: 13-, where B-Tree deduplication was introduced.
src/backend/access/nbtree/nbtinsert.c
src/backend/access/table/tableam.c
src/include/access/tableam.h