pg_upgrade: generate check error for left-over new tablespace
authorBruce Momjian <bruce@momjian.us>
Thu, 15 Oct 2020 23:33:36 +0000 (19:33 -0400)
committerBruce Momjian <bruce@momjian.us>
Thu, 15 Oct 2020 23:33:36 +0000 (19:33 -0400)
commit85fedf39f07ecd5f7008eab04d03a4705716d1fe
treef94edfc931b20168bc051f0c90b2235e60055503
parented4a1c873649b4ababbe5b92ad17e9a29215f168
pg_upgrade:  generate check error for left-over new tablespace

Previously, if pg_upgrade failed, and the user recreated the cluster but
did not remove the new cluster tablespace directory, a later pg_upgrade
would fail since the new tablespace directory would already exists.
This adds error reporting for this during check.

Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20200925005531.GJ23631@telsasoft.com

Backpatch-through: 9.5
src/bin/pg_upgrade/check.c