From 91da65f4ac2837e0792071e42b2e2101059f1b1b Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 24 Nov 2019 12:03:16 -0500 Subject: [PATCH] Remove a couple of unnecessary if-tests. Commit abd9ca377 replaced a couple of while-loops in fmtfloat() with calls to dopr_outchmulti, but I (tgl) failed to notice that the new if-tests guarding those calls were really unnecessary, because they're inside a larger if-block checking the same thing. Ranier Vilela Discussion: https://postgr.es/m/MN2PR18MB2927850AB00CF39CC370D107E34B0@MN2PR18MB2927.namprd18.prod.outlook.com --- src/port/snprintf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/port/snprintf.c b/src/port/snprintf.c index e4bb15dfec1..5c827ef6fe4 100644 --- a/src/port/snprintf.c +++ b/src/port/snprintf.c @@ -1227,16 +1227,14 @@ fmtfloat(double value, char type, int forcesign, int leftjust, { /* pad before exponent */ dostr(convert, epos - convert, target); - if (zeropadlen > 0) - dopr_outchmulti('0', zeropadlen, target); + dopr_outchmulti('0', zeropadlen, target); dostr(epos, vallen - (epos - convert), target); } else { /* no exponent, pad after the digits */ dostr(convert, vallen, target); - if (zeropadlen > 0) - dopr_outchmulti('0', zeropadlen, target); + dopr_outchmulti('0', zeropadlen, target); } } else -- 2.39.5