Avoid bogus scans of partitions when validating FKs to partitioned tables
authorÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 5 Jun 2025 15:17:13 +0000 (17:17 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 5 Jun 2025 15:17:13 +0000 (17:17 +0200)
commitcc733ed164c5b57fdf34d16e4cc8e9bbdc171699
tree76097feecaf703d3d27a84b1cf8d56c453b7ab19
parent4b05ebf0957bc796b9ea8f4d2ab5985714ef3252
Avoid bogus scans of partitions when validating FKs to partitioned tables

Validating an unvalidated foreign key that references a partitioned
table would try to queue validations for each individual partition of
the referenced table, but this is wrong: each individual partition would
not necessarily have all the referenced rows, so errors would be raised.
Avoid doing that.  The pg_constraint rows that cause this to happen are
only there to support the action triggers that implement the DELETE/
UPDATE actions of the FK, so no validating scan is necessary.

This was an oversight in commit b663b9436e75.

An equivalent oversight exists for NOT ENFORCED constraints, which is
not fixed in this commit.

Author: Amul Sul <sulamul@gmail.com>
Reported-by: Antonin Houska <ah@cybertec.at>
Reviewed-by: jian he <jian.universality@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Discussion: https://postgr.es/m/26983.1748418675@localhost
src/backend/commands/tablecmds.c
src/test/regress/expected/foreign_key.out
src/test/regress/sql/foreign_key.sql