Attempt threading in this order:
authorBruce Momjian <bruce@momjian.us>
Sat, 13 Sep 2003 14:49:51 +0000 (14:49 +0000)
committerBruce Momjian <bruce@momjian.us>
Sat, 13 Sep 2003 14:49:51 +0000 (14:49 +0000)
 *      use non-*_r function names if they are all thread-safe
 *          (NEED_REENTRANT_FUNCS=no)
 *      use *_r functions if they exist (configure test)
 *      do our own locking and copying of non-threadsafe functions

New to this patch is the last option.

configure.in
src/include/port.h
src/port/thread.c
src/template/bsdi
src/template/freebsd
src/template/linux
src/template/netbsd
src/template/osf
src/template/solaris
src/template/unixware

index 62c14eeb28699a61c08116a19562b981704ecab9..9ca208f5f3f3d6c59f8102c762c5a89386c99eb0 100644 (file)
@@ -1,5 +1,5 @@
 dnl Process this file with autoconf to produce a configure script.
-dnl $Header: /cvsroot/pgsql/configure.in,v 1.287 2003/09/12 16:10:26 momjian Exp $
+dnl $Header: /cvsroot/pgsql/configure.in,v 1.288 2003/09/13 14:49:51 momjian Exp $
 dnl
 dnl Developers, please strive to achieve this order:
 dnl
@@ -1031,17 +1031,12 @@ AC_SUBST(THREAD_LIBS)
 # One trick here is that if we don't call AC_CHECK_FUNCS, the
 # functions are marked "not found", which is perfect.
 #
-if test "$enable_thread_safety" = yes -a "$NEED_REENTRANT_FUNC_NAMES" = yes ; then
+if test "$enable_thread_safety" = yes -a "$NEED_REENTRANT_FUNCS" = yes ; then
 _CFLAGS="$CFLAGS"
 _LIBS="$LIBS"
 CFLAGS="$CFLAGS $THREAD_CFLAGS"
 LIBS="$LIBS $THREAD_LIBS"
-AC_CHECK_FUNC(strerror_r,
-       [], [AC_MSG_ERROR([strerror_r not found, required on this platform for --enable-thread-safety])])
-AC_CHECK_FUNC(getpwuid_r,
-       [], [AC_MSG_ERROR([getpwuid_r not found, required on this platform for --enable-thread-safety])])
-AC_CHECK_FUNC(gethostbyname_r,
-       [], [AC_MSG_ERROR([gethostbyname_r not found, required on this platform for --enable-thread-safety])])
+AC_CHECK_FUNCS([strerror_r getpwuid_r gethostbyname_r])
 CFLAGS="$_CFLAGS"
 LIBS="$_LIBS"
 fi
index 6b801ba424a223b37e594b11e39f679b92ee0f1a..d77dd652f15fde90e515b39d6944f3ec3738700e 100644 (file)
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Id: port.h,v 1.13 2003/09/05 17:43:39 momjian Exp $
+ * $Id: port.h,v 1.14 2003/09/13 14:49:51 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -114,11 +114,11 @@ extern char *pqStrerror(int errnum, char *strerrbuf, size_t buflen);
 
 #ifndef WIN32
 extern int pqGetpwuid(uid_t uid, struct passwd * resultbuf, char *buffer,
-                  size_t buflen, struct passwd ** result);
+                  size_t buflen, struct passwd **result);
 #endif
 
 extern int pqGethostbyname(const char *name,
-                               struct hostent * resbuf,
-                               char *buf, size_t buflen,
-                               struct hostent ** result,
+                               struct hostent *resultbuf,
+                               char *buffer, size_t buflen,
+                               struct hostent **result,
                                int *herrno);
index c00202a0631d13221c486a69a2b72b6c06803c6c..193b2e0808b43a33162227d36a9dee1de5ce2112 100644 (file)
@@ -7,19 +7,24 @@
  *
  * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
  *
- * $Id: thread.c,v 1.6 2003/09/05 17:43:40 momjian Exp $
+ * $Id: thread.c,v 1.7 2003/09/13 14:49:51 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
 
 #include "postgres.h"
 
+#include <pthread.h>
+#include <sys/types.h>
+#include <pwd.h>
+
 /*
  *     Threading sometimes requires specially-named versions of functions
  *     that return data in static buffers, like strerror_r() instead of
  *     strerror().  Other operating systems use pthread_setspecific()
  *     and pthread_getspecific() internally to allow standard library
- *     functions to return static data to threaded applications.
+ *     functions to return static data to threaded applications. And some
+ *     operating systems have neither, meaning we have to do our own locking.
  *
  *     Additional confusion exists because many operating systems that
  *     use pthread_setspecific/pthread_getspecific() also have *_r versions
  *     doesn't have strerror_r(), so we can't fall back to only using *_r
  *     functions for threaded programs.
  *
- *     The current setup is to assume either all standard functions are
- *     thread-safe (NEED_REENTRANT_FUNC_NAMES=no), or the operating system
- *     requires reentrant function names (NEED_REENTRANT_FUNC_NAMES=yes).
+ *     The current setup is to try threading in this order:
+ *
+ *             use non-*_r function names if they are all thread-safe
+ *                     (NEED_REENTRANT_FUNCS=no)
+ *             use *_r functions if they exist (configure test)
+ *             do our own locking and copying of non-threadsafe functions
+ *
  *     Compile and run src/tools/test_thread_funcs.c to see if your operating
- *     system requires reentrant function names.
+ *     system has thread-safe non-*_r functions.
  */
  
 
 char *
 pqStrerror(int errnum, char *strerrbuf, size_t buflen)
 {
-#if defined(USE_THREADS) && defined(NEED_REENTRANT_FUNC_NAMES)
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && defined(HAVE_STRERROR_R)
        /* reentrant strerror_r is available */
        /* some early standards had strerror_r returning char * */
        strerror_r(errnum, strerrbuf, buflen);
-       return (strerrbuf);
+       return strerrbuf;
+
 #else
+
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_STRERROR_R)
+       static pthread_mutex_t strerror_lock = PTHREAD_MUTEX_INITIALIZER;
+       pthread_mutex_lock(&strerror_lock);
+#endif
+
        /* no strerror_r() available, just use strerror */
-       return strerror(errnum);
+       StrNCpy(strerrbuf, strerror(errnum), buflen);
+
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_STRERROR_R)
+       pthread_mutex_unlock(&strerror_lock);
+#endif
+
+       return strerrbuf;
 #endif
 }
 
@@ -71,7 +93,7 @@ int
 pqGetpwuid(uid_t uid, struct passwd *resultbuf, char *buffer,
                   size_t buflen, struct passwd **result)
 {
-#if defined(USE_THREADS) && defined(NEED_REENTRANT_FUNC_NAMES)
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && defined(HAVE_GETPWUID_R)
        /*
         * Early POSIX draft of getpwuid_r() returns 'struct passwd *'.
         *    getpwuid_r(uid, resultbuf, buffer, buflen)
@@ -79,9 +101,52 @@ pqGetpwuid(uid_t uid, struct passwd *resultbuf, char *buffer,
         */
        /* POSIX version */
        getpwuid_r(uid, resultbuf, buffer, buflen, result);
+
 #else
+
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_GETPWUID_R)
+       static pthread_mutex_t getpwuid_lock = PTHREAD_MUTEX_INITIALIZER;
+       pthread_mutex_lock(&getpwuid_lock);
+#endif
+
        /* no getpwuid_r() available, just use getpwuid() */
        *result = getpwuid(uid);
+
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_GETPWUID_R)
+
+       /* Use 'buffer' memory for storage of strings used by struct passwd */
+       if (*result &&
+               strlen((*result)->pw_name) + 1 +
+               strlen((*result)->pw_passwd) + 1 +
+               strlen((*result)->pw_gecos) + 1 +
+               /* skip class if it exists */
+               strlen((*result)->pw_dir) + 1 +
+               strlen((*result)->pw_shell) + 1 <= buflen)
+       {
+               memcpy(resultbuf, *result, sizeof(struct passwd));
+               strcpy(buffer, (*result)->pw_name);
+               resultbuf->pw_name = buffer;
+               buffer += strlen(resultbuf->pw_name) + 1;
+               strcpy(buffer, (*result)->pw_passwd);
+               resultbuf->pw_passwd = buffer;
+               buffer += strlen(resultbuf->pw_passwd) + 1;
+               strcpy(buffer, (*result)->pw_gecos);
+               resultbuf->pw_gecos = buffer;
+               buffer += strlen(resultbuf->pw_gecos) + 1;
+               strcpy(buffer, (*result)->pw_dir);
+               resultbuf->pw_dir = buffer;
+               buffer += strlen(resultbuf->pw_dir) + 1;
+               strcpy(buffer, (*result)->pw_shell);
+               resultbuf->pw_shell = buffer;
+               buffer += strlen(resultbuf->pw_shell) + 1;
+
+               *result = resultbuf;
+       }
+       else
+               *result = NULL;
+
+       pthread_mutex_unlock(&getpwuid_lock);
+#endif
 #endif
        return (*result == NULL) ? -1 : 0;
 }
@@ -93,27 +158,101 @@ pqGetpwuid(uid_t uid, struct passwd *resultbuf, char *buffer,
  */
 int
 pqGethostbyname(const char *name,
-                               struct hostent *resbuf,
-                               char *buf, size_t buflen,
+                               struct hostent *resultbuf,
+                               char *buffer, size_t buflen,
                                struct hostent **result,
                                int *herrno)
 {
-#if defined(USE_THREADS) && defined(NEED_REENTRANT_FUNC_NAMES)
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && defined(HAVE_GETHOSTBYNAME_R)
        /*
         * broken (well early POSIX draft) gethostbyname_r() which returns
         * 'struct hostent *'
         */
-       *result = gethostbyname_r(name, resbuf, buf, buflen, herrno);
+       *result = gethostbyname_r(name, resbuf, buffer, buflen, herrno);
        return (*result == NULL) ? -1 : 0;
+
 #else
+
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_GETHOSTBYNAME_R)
+       static pthread_mutex_t gethostbyname_lock = PTHREAD_MUTEX_INITIALIZER;
+       pthread_mutex_lock(&gethostbyname_lock);
+#endif
+
        /* no gethostbyname_r(), just use gethostbyname() */
        *result = gethostbyname(name);
+
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_GETHOSTBYNAME_R)
+
+       /*
+        *      Use 'buffer' memory for storage of structures used by struct hostent.
+        *      The layout is:
+        *
+        *              addr pointers
+        *              alias pointers
+        *              addr structures
+        *              alias structures
+        *              name
+        */
+       if (*result)
+       {
+               int             i, pointers = 2 /* for nulls */, len = 0;
+               char    **pbuffer;
+
+               for (i = 0; (*result)->h_addr_list[i]; i++, pointers++)
+                       len += (*result)->h_length;
+               for (i = 0; (*result)->h_aliases[i]; i++, pointers++)
+                       len += (*result)->h_length;
+
+               if (MAXALIGN(len) + pointers * sizeof(char *) + strlen((*result)->h_name) + 1 <= buflen)
+               {
+                       memcpy(resultbuf, *result, sizeof(struct hostent));
+
+               pbuffer = (char **)buffer;
+               resultbuf->h_addr_list = pbuffer;
+               buffer += pointers * sizeof(char *);
+
+                       for (i = 0; (*result)->h_addr_list[i]; i++, pbuffer++)
+                       {
+                               memcpy(buffer, (*result)->h_addr_list[i], (*result)->h_length);
+                       resultbuf->h_addr_list[i] = buffer;
+                       buffer += (*result)->h_length;
+               }
+                       resultbuf->h_addr_list[i] = NULL;
+                       pbuffer++;
+                           
+               resultbuf->h_aliases = pbuffer;
+
+                       for (i = 0; (*result)->h_aliases[i]; i++, pbuffer++)
+                       {
+                               memcpy(buffer, (*result)->h_aliases[i], (*result)->h_length);
+                       resultbuf->h_aliases[i] = buffer;
+                       buffer += (*result)->h_length;
+               }
+                       resultbuf->h_aliases[i] = NULL;
+                       pbuffer++;
+
+                       /* Place at end for cleaner alignment */                        
+                       strcpy(buffer, (*result)->h_name);
+                       resultbuf->h_name = buffer;
+                       buffer += strlen(resultbuf->h_name) + 1;
+
+                       *result = resultbuf;
+               }
+               else
+                       *result = NULL;
+       }
+#endif
+
+       if (*result != NULL)
+               *herrno = h_errno;
+               
+#if defined(FRONTEND) && defined(USE_THREADS) && defined(NEED_REENTRANT_FUNCS) && !defined(HAVE_GETHOSTBYNAME_R)
+       pthread_mutex_unlock(&gethostbyname_lock);
+#endif
+
        if (*result != NULL)
                return 0;
        else
-       {
-               *herrno = h_errno;
                return -1;
-       }
 #endif
 }
index ba2d27247e4621945a06f06fc7f9ed1cf1e9c779..d6b16a2417d2a784b59d99f8e0688f307df26c3a 100644 (file)
@@ -11,4 +11,4 @@ case $host_os in
 esac
 
 SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=no   # verified 4.3 2003-09-03
+NEED_REENTRANT_FUNCS=no        # verified 4.3 2003-09-03
index 9e5cc6d01280e21d3389336e65b9caf815c4d1f9..71e501406607e0a1befd1927bc2fdc15a54c53bd 100644 (file)
@@ -4,8 +4,8 @@ case $host_cpu in
   alpha*)   CFLAGS="$CFLAGS -O" ;;
 esac
 
-SUPPORTS_THREADS=no    # 4.8, 5.1  2003-09-12
-NEED_REENTRANT_FUNC_NAMES=no
+SUPPORTS_THREADS=yes
+NEED_REENTRANT_FUNCS=yes       # 4.8, 5.1  2003-09-12
 
 case $host_os in
                freebsd2*|freebsd3*|freebsd4*)
index db13803710ec60f8be870ff10dca8f56f1a7e645..0aab11631f5e5f0881e378845513a0f75d8b0852 100644 (file)
@@ -1,7 +1,7 @@
 CFLAGS=-O2
 
 SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=yes  # verified glibc 2.1 2003-09-03
+NEED_REENTRANT_FUNCS=yes       # verified glibc 2.1 2003-09-03
 THREAD_CFLAGS="-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS"
 THREAD_LIBS="-lpthread"
 
index 9a3869dfe77044a7883d4e9c11c55de1c01b9d0b..72e1d624c4ae8ec5466eb59cff59889877d08eb5 100644 (file)
@@ -1,4 +1,4 @@
 CFLAGS='-O2 -pipe'
 
 SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=no
+NEED_REENTRANT_FUNCS=no
index a930bf4e08ee111a686265328a741c98001ad248..7305395a0b2e23c38deb21f7fe0753bdabbf78d9 100644 (file)
@@ -6,5 +6,5 @@ else
 fi
 
 SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=no
+NEED_REENTRANT_FUNCS=no                # 4.0 2003-09-13
 THREAD_CFLAGS="-pthread"
index 33d40cfb87cef3f670845f8535613a36540be69d..d839f935ccb4701506b6329d4cd3cd95d5cd5167 100644 (file)
@@ -4,3 +4,8 @@ else
   CC="$CC -Xa"                 # relaxed ISO C mode
   CFLAGS=-v                    # -v is like gcc -Wall
 fi
+
+SUPPORTS_THREADS=yes
+NEED_REENTRANT_FUNCS=yes       # 5.6 2003-09-13
+THREAD_CFLAGS="-pthread"
+
index 9cfde833c921aea7b88cec7e9cf8cadd20334850..21d4314d87d549399ab33f816fc02a57eaa0dda9 100644 (file)
@@ -10,5 +10,5 @@ else
 fi
 
 SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=no   # verified 7.1.3 2003-09-03
+NEED_REENTRANT_FUNCS=no                # verified 7.1.3 2003-09-03
 THREAD_CFLAGS="$THREAD_CFLAGS -D_REENTRANT"