Remove StoreSingleInheritance reimplementation

I introduced this duplicate code in commit 8b08f7d4820f for no good
reason.  Remove it, and backpatch to 11 where it was introduced.

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>

diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
index df962cb93835bc04840591da7fa4d2b3061b4fa3..db83d20e68730bac3a5a23a8cac087ef6ea9fbdc 100644 (file)
--- a/src/backend/commands/indexcmds.c
+++ b/src/backend/commands/indexcmds.c
@@ -2664,23 +2664,7 @@ IndexSetParentIndex(Relation partitionIdx, Oid parentOid)
        }
        else
        {
-           Datum       values[Natts_pg_inherits];
-           bool        isnull[Natts_pg_inherits];
-
-           /*
-            * No pg_inherits row exists, and we want a parent for this index,
-            * so insert it.
-            */
-           values[Anum_pg_inherits_inhrelid - 1] = ObjectIdGetDatum(partRelid);
-           values[Anum_pg_inherits_inhparent - 1] =
-               ObjectIdGetDatum(parentOid);
-           values[Anum_pg_inherits_inhseqno - 1] = Int32GetDatum(1);
-           memset(isnull, false, sizeof(isnull));
-
-           tuple = heap_form_tuple(RelationGetDescr(pg_inherits),
-                                   values, isnull);
-           CatalogTupleInsert(pg_inherits, tuple);
-
+           StoreSingleInheritance(partRelid, parentOid, 1);
            fix_dependencies = true;
        }
    }