Blind fix for uninitialized memory bug in ba9a7e392171
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Sun, 20 Mar 2022 21:10:24 +0000 (22:10 +0100)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Sun, 20 Mar 2022 21:10:24 +0000 (22:10 +0100)
Valgrind animal skink shows a crash in this new code.  I couldn't
reproduce the problem locally, but going by blind code inspection,
initializing insert_destrel should be sufficient to fix the problem.

src/backend/executor/nodeModifyTable.c

index 5e4226abe26c362066a681de010f2ea0a772f2ab..701fe05296736ae9d11242a43290be4a9c9caca7 100644 (file)
@@ -1820,7 +1820,7 @@ lreplace:;
    if (partition_constraint_failed)
    {
        TupleTableSlot *inserted_tuple;
-       ResultRelInfo *insert_destrel;
+       ResultRelInfo *insert_destrel = NULL;
 
        /*
         * ExecCrossPartitionUpdate will first DELETE the row from the