Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.
authorNoah Misch <noah@leadboat.com>
Sat, 30 Jan 2021 08:00:27 +0000 (00:00 -0800)
committerNoah Misch <noah@leadboat.com>
Sat, 30 Jan 2021 08:02:08 +0000 (00:02 -0800)
commitd1ab4bf6ed2d5d5026e13af510d0d3b025fa6ac9
tree06806818465e33354cacc3efb09102460533d050
parent289ef386dff6662b1c1cf90d0666a3863bcf5ba8
Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.

In a cluster having used CREATE INDEX CONCURRENTLY while having enabled
prepared transactions, queries that use the resulting index can silently
fail to find rows.  Fix this for future CREATE INDEX CONCURRENTLY by
making it wait for prepared transactions like it waits for ordinary
transactions.  This expands the VirtualTransactionId structure domain to
admit prepared transactions.  It may be necessary to reindex to recover
from past occurrences.  Back-patch to 9.5 (all supported versions).

Andrey Borodin, reviewed (in earlier versions) by Tom Lane and Michael
Paquier.

Discussion: https://postgr.es/m/2E712143-97F7-4890-B470-4A35142ABC82@yandex-team.ru
src/backend/storage/lmgr/lmgr.c
src/backend/storage/lmgr/lock.c
src/include/storage/lock.h
src/test/isolation/Makefile
src/test/isolation/README
src/test/isolation/expected/prepared-transactions-cic.out [new file with mode: 0644]
src/test/isolation/specs/prepared-transactions-cic.spec [new file with mode: 0644]