Demote pg_unreachable() in heapam to an assertion.
authorPeter Geoghegan <pg@bowt.ie>
Fri, 29 Oct 2021 17:53:46 +0000 (10:53 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Fri, 29 Oct 2021 17:53:46 +0000 (10:53 -0700)
commitbd9f4cf0ee5336ce4f9f3103521740baccfb3825
tree997596a2494680faa2d9c9b78e1924862949b2c2
parent0c8a40b391191793afe8f1e202765a5b71bccea5
Demote pg_unreachable() in heapam to an assertion.

Commit d168b66682, which overhauled index deletion, added a
pg_unreachable() to the end of a sort comparator used when sorting heap
TIDs from an index page.  This allows the compiler to apply
optimizations that assume that the heap TIDs from the index AM must
always be unique.

That doesn't seem like a good idea now, given recent reports of
corruption involving duplicate TIDs in indexes on Postgres 14.  Demote
to an assertion, just in case.

Backpatch: 14-, where index deletion was overhauled.
src/backend/access/heap/heapam.c