Avoid memcpy() with same source and destination during relmapper init.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Dec 2020 20:46:44 +0000 (15:46 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 18 Dec 2020 20:46:44 +0000 (15:46 -0500)
commit21b2ee6ee376c0c9d05dd1edfa8d68c87ffcbd0a
tree0121a770c79bd082d39eff430e5735345c49c551
parent48cbed8821120b378e22be1f0d3cfcf61ef0d1e4
Avoid memcpy() with same source and destination during relmapper init.

A narrow reading of the C standard says that memcpy(x,x,n) is undefined,
although it's hard to envision an implementation that would really
misbehave.  However, analysis tools such as valgrind might whine about
this; accordingly, let's band-aid relmapper.c to not do it.

See also 5b630501ed3f4e8a8aad7b48ea0, and other similar fixes.
Apparently, none of those folk tried valgrinding initdb?  This has been
like this for long enough that I'm surprised it hasn't been reported
before.

Back-patch, just in case anybody wants to use a back branch on a platform
that complains about this; we back-patched those earlier fixes too.

Discussion: https://postgr.es/m/161790.1608310142@sss.pgh.pa.us
src/backend/utils/cache/relmapper.c