Make manager a required field on teams master github/master
authorMagnus Hagander <magnus@hagander.net>
Fri, 9 Jan 2026 10:04:15 +0000 (11:04 +0100)
committerMagnus Hagander <magnus@hagander.net>
Fri, 9 Jan 2026 10:04:15 +0000 (11:04 +0100)
This was left as NULLable when created to make the migration path
simpler, but it's now set on all teams and there are parts of the code
that relies on it being set, so enforce it in the database.

hamnadmin/hamnadmin/register/migrations/0008_require_team_manager.py [new file with mode: 0644]
hamnadmin/hamnadmin/register/models.py

diff --git a/hamnadmin/hamnadmin/register/migrations/0008_require_team_manager.py b/hamnadmin/hamnadmin/register/migrations/0008_require_team_manager.py
new file mode 100644 (file)
index 0000000..61a41e6
--- /dev/null
@@ -0,0 +1,21 @@
+# Generated by Django 4.2.11 on 2026-01-09 10:03
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
+        ('register', '0007_moderatornotes'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='team',
+            name='manager',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL),
+        ),
+    ]
index 66c99ea528ddebc5aa681a6a3769b5a645308d22..f4e3b8645e831c2ac506d91804b473ed28292570 100644 (file)
@@ -8,7 +8,7 @@ from hamnadmin.util.shortlink import urlvalmap
 class Team(models.Model):
     teamurl = models.CharField(max_length=255, blank=False)
     name = models.CharField(max_length=255, blank=False)
-    manager = models.ForeignKey(User, null=True, blank=True, on_delete=models.CASCADE)
+    manager = models.ForeignKey(User, null=False, blank=False, on_delete=models.CASCADE)
 
     def __str__(self):
         return "%s (%s)" % (self.name, self.teamurl)