From f7b711c8bcef46c67dc5345b983752ac833e51ad Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 15 Mar 2017 07:21:17 -0400 Subject: [PATCH] Cosmetic fixes for hash index write-ahead logging. Amit Kapila. One of these was reported by Tom Lane. Discussion: http://postgr.es/m/5515.1489514099@sss.pgh.pa.us --- src/backend/access/hash/README | 3 --- src/backend/access/hash/hashpage.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/backend/access/hash/README b/src/backend/access/hash/README index 00beb86ffa..53b0e0def1 100644 --- a/src/backend/access/hash/README +++ b/src/backend/access/hash/README @@ -365,9 +365,6 @@ try to split the bucket again until the prior split is finished. In other words, a bucket can be in the middle of being split for some time, but it can't be in the middle of two splits at the same time. -Although we can survive a failure to split a bucket, a crash is likely to -corrupt the index, since hash indexes are not yet WAL-logged. - The fourth operation is garbage collection (bulk deletion): next bucket := 0 diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index dc606f162e..622cc4b837 100644 --- a/src/backend/access/hash/hashpage.c +++ b/src/backend/access/hash/hashpage.c @@ -975,7 +975,7 @@ fail: * hash indexes sequentially anyway, that probably doesn't matter. * * XXX It's annoying that this code is executed with the metapage lock held. - * We need to interlock against _hash_getovflpage() adding a new overflow page + * We need to interlock against _hash_addovflpage() adding a new overflow page * concurrently, but it'd likely be better to use LockRelationForExtension * for the purpose. OTOH, adding a splitpoint is a very infrequent operation, * so it may not be worth worrying about. -- 2.39.5