When WalSndCaughtUp, sleep only in WalSndWaitForWal().
authorNoah Misch <noah@leadboat.com>
Sat, 11 Apr 2020 17:30:00 +0000 (10:30 -0700)
committerNoah Misch <noah@leadboat.com>
Sat, 11 Apr 2020 17:30:00 +0000 (10:30 -0700)
commit421685812290406daea58b78dfab0346eb683bbb
tree84e435a42fb61d2363c725f35bccb4c3d575846e
parent969f9d0b4ba574bb8df65683dbf7a09c030f3e67
When WalSndCaughtUp, sleep only in WalSndWaitForWal().

Before sleeping, WalSndWaitForWal() sends a keepalive if MyWalSnd->write
< sentPtr.  That is important in logical replication.  When the latest
physical LSN yields no logical replication messages (a common case),
that keepalive elicits a reply, and processing the reply updates
pg_stat_replication.replay_lsn.  WalSndLoop() lacks that; when
WalSndLoop() slept, replay_lsn advancement could stall until
wal_receiver_status_interval elapsed.  This sometimes stalled
src/test/subscription/t/001_rep_changes.pl for up to 10s.

Discussion: https://postgr.es/m/20200406063649.GA3738151@rfd.leadboat.com
src/backend/replication/walsender.c