Update error messages, per notes from Tom.

Laurenz Albe

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 7ed3a7187dc042a9ab9c50a2be68bd1feafb3616..9c16654abcc44c9ae6241d4f64fc00e60baa4bab 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -7101,14 +7101,15 @@ CancelBackup(void)
        {
                ereport(LOG,
                                (errmsg("online backup mode cancelled"),
-                                errdetail("\"%s\" renamed to \"%s\"",
+                                errdetail("\"%s\" was renamed to \"%s\".",
                                                BACKUP_LABEL_FILE, BACKUP_LABEL_OLD)));
        }
        else
        {
                ereport(WARNING,
                                (errcode_for_file_access(),
-                                errmsg("could not rename \"%s\" to \"%s\", backup mode not cancelled: %m",
+                                errmsg("online backup mode was not cancelled"),
+                                errdetail("Could not rename \"%s\" to \"%s\": %m.",
                                                BACKUP_LABEL_FILE, BACKUP_LABEL_OLD)));
        }
 }

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index ec4385cfac157619ef602ede085cf7a6c0d32bd8..37757dd7fab5be01b5cab64ee6a3981d5438bd17 100644 (file)
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -767,8 +767,8 @@ do_stop(void)
        {
                if ((shutdown_mode == SMART_MODE) && (stat(backup_file, &statbuf) == 0))
                {
-                       print_msg(_("WARNING: online backup mode is active; must be ended\n"
-                                               "   with pg_stop_backup() for shutdown to complete\n\n"));
+                       print_msg(_("WARNING: online backup mode is active.\n"
+                                               "Shutdown will not complete until pg_stop_backup() is called.\n\n"));
                }
 
                print_msg(_("waiting for server to shut down..."));
@@ -844,8 +844,8 @@ do_restart(void)
 
                if ((shutdown_mode == SMART_MODE) && (stat(backup_file, &statbuf) == 0))
                {
-                       print_msg(_("WARNING: online backup mode is active; must be ended\n"
-                                               "   with pg_stop_backup() for shutdown to complete\n\n"));
+                       print_msg(_("WARNING: online backup mode is active.\n"
+                                               "Shutdown will not complete until pg_stop_backup() is called.\n\n"));
                }
 
                print_msg(_("waiting for server to shut down..."));