Fix bug in the WAL recovery code to finish an incomplete split.

CacheInvalidateRelcache() crashes if called in WAL recovery, because the
invalidation infrastructure hasn't been initialized yet.

Back-patch to 8.2, where the bug was introduced.

diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
index 15d4f4306d43936579e64696b67b91dcdb3ff898..5293179ed4d3fa2208bb2648c3006f6e11cc2649 100644 (file)
--- a/src/backend/access/nbtree/nbtinsert.c
+++ b/src/backend/access/nbtree/nbtinsert.c
@@ -747,7 +747,8 @@ _bt_insertonpg(Relation rel,
                /* release buffers; send out relcache inval if metapage changed */
                if (BufferIsValid(metabuf))
                {
-                       CacheInvalidateRelcache(rel);
+                       if (!InRecovery)
+                               CacheInvalidateRelcache(rel);
                        _bt_relbuf(rel, metabuf);
                }
 
@@ -1792,7 +1793,8 @@ _bt_newroot(Relation rel, Buffer lbuf, Buffer rbuf)
        END_CRIT_SECTION();
 
        /* send out relcache inval for metapage change */
-       CacheInvalidateRelcache(rel);
+       if (!InRecovery)
+               CacheInvalidateRelcache(rel);
 
        /* done with metapage */
        _bt_relbuf(rel, metabuf);