If RelationBuildDesc() fails to open a critical system index, PANIC with

a relevant error message instead of just dumping core.  Odd that nobody
reported this before Darren Reed.

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 5361790ccd6be3dd1f1b3c4af4aeef4589e30857..d88fa5478e80df06d46fa83a7f01162465359224 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -2550,7 +2550,10 @@ RelationCacheInitializePhase2(void)
 
 #define LOAD_CRIT_INDEX(indexoid) \
                do { \
-                       ird = RelationBuildDesc((indexoid), NULL); \
+                       ird = RelationBuildDesc(indexoid, NULL); \
+                       if (ird == NULL) \
+                               elog(PANIC, "could not open critical system index %u", \
+                                        indexoid); \
                        ird->rd_isnailed = true; \
                        ird->rd_refcnt = 1; \
                } while (0)