Check DCH_MAX_ITEM_SIZ limits with <=, not <.

We reserve space for the full amount, not one less.  The affected checks
deal with localized month and day names.  Today's DCH_MAX_ITEM_SIZ value
would suffice for a 60-byte day name, while the longest known is the
49-byte mn_CN.utf-8 word for "Saturday."  Thus, the upshot of this
change is merely to avoid misdirecting future readers of the code; users
are not expected to see errors either way.

diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
index 8d5313832070c326af9510e8c07d2c456ef040d9..40a353f5134cb7766ed567ef9b975bb530b1f6fe 100644 (file)
--- a/src/backend/utils/adt/formatting.c
+++ b/src/backend/utils/adt/formatting.c
@@ -2543,7 +2543,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_toupper_z(localized_full_months[tm->tm_mon - 1], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2563,7 +2563,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_initcap_z(localized_full_months[tm->tm_mon - 1], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2583,7 +2583,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_tolower_z(localized_full_months[tm->tm_mon - 1], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2603,7 +2603,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_toupper_z(localized_abbrev_months[tm->tm_mon - 1], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2622,7 +2622,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_initcap_z(localized_abbrev_months[tm->tm_mon - 1], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2641,7 +2641,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_tolower_z(localized_abbrev_months[tm->tm_mon - 1], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2664,7 +2664,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_toupper_z(localized_full_days[tm->tm_wday], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2682,7 +2682,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_initcap_z(localized_full_days[tm->tm_wday], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2700,7 +2700,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_tolower_z(localized_full_days[tm->tm_wday], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2718,7 +2718,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_toupper_z(localized_abbrev_days[tm->tm_wday], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2735,7 +2735,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_initcap_z(localized_abbrev_days[tm->tm_wday], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,
@@ -2752,7 +2752,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
                                {
                                        char *str = str_tolower_z(localized_abbrev_days[tm->tm_wday], collid);
 
-                                       if (strlen(str) < (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
+                                       if (strlen(str) <= (n->key->len + TM_SUFFIX_LEN) * DCH_MAX_ITEM_SIZ)
                                                strcpy(s, str);
                                        else
                                                ereport(ERROR,