Cope with inplace update making catcache stale during TOAST fetch.
authorNoah Misch <noah@leadboat.com>
Fri, 28 Jun 2024 02:21:06 +0000 (19:21 -0700)
committerNoah Misch <noah@leadboat.com>
Fri, 28 Jun 2024 02:21:06 +0000 (19:21 -0700)
commitf9f47f0d93d1a493a3365625f96026c7b18d7cf5
treea35c51f21bddc89825a64df1cca17ee5b255300b
parent5b823b179e5e8ab32f140658698ca08f8c83f06e
Cope with inplace update making catcache stale during TOAST fetch.

This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of
inplace updates.  Trouble requires an inplace update of a catalog having
a TOAST table, so only pg_database was at risk.  (The other catalog on
which core code performs inplace updates, pg_class, has no TOAST table.)
Trouble would require something like the inplace-inval.spec test.
Consider GRANT ... ON DATABASE fetching a stale row from cache and
discarding a datfrozenxid update that vac_truncate_clog() has already
relied upon.  Back-patch to v12 (all supported versions).

Reviewed (in an earlier version) by Robert Haas.

Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com
Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com
src/backend/catalog/catalog.c
src/backend/utils/cache/catcache.c
src/include/catalog/catalog.h