Disable WAL-skipping optimization for COPY on views and foreign tables
authorMichael Paquier <michael@paquier.xyz>
Sun, 23 Dec 2018 07:42:22 +0000 (16:42 +0900)
committerMichael Paquier <michael@paquier.xyz>
Sun, 23 Dec 2018 07:42:22 +0000 (16:42 +0900)
commitbf491a9073e12ce1fc3e6facd0ae1308534df570
tree9cd8cd5ce2f5e21d32227592d82dd0fa830e37d2
parent11a60d496147a1e1bbf6932bda53941c5a62ee1a
Disable WAL-skipping optimization for COPY on views and foreign tables

COPY can skip writing WAL when loading data on a table which has been
created in the same transaction as the one loading the data, however
this cannot work on views or foreign table as this would result in
trying to flush relation files which do not exist.  So disable the
optimization so as commands are able to work the same way with any
configuration of wal_level.

Tests are added to cover the different cases, which need to have
wal_level set to minimal to allow the problem to show up, and that is
not the default configuration.

Reported-by: Luis M. Carril, Etsuro Fujita
Author: Amit Langote, Michael Paquier
Reviewed-by: Etsuro Fujita
Discussion: https://postgr.es/m/15552-c64aa14c5c22f63c@postgresql.org
Backpatch-through: 10, where support for COPY on views has been added,
while v11 has added support for COPY on foreign tables.
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql
src/backend/commands/copy.c
src/test/regress/expected/copy2.out
src/test/regress/sql/copy2.sql