Fix pg_basebackup output to stdout on Windows.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 14 Jul 2017 13:02:53 +0000 (16:02 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 14 Jul 2017 13:02:53 +0000 (16:02 +0300)
commit8046465c2ecf6841ad80265f84294edd98aefd8b
treeb54e6cdc10c293d4da748418cdb52c43f9f785f1
parenta3ca72ae9ac14acb2b1b9cd207ac0c8a01f1439a
Fix pg_basebackup output to stdout on Windows.

When writing a backup to stdout with pg_basebackup on Windows, put stdout
to binary mode. Any CR bytes in the output will otherwise be output
incorrectly as CR+LF.

In the passing, standardize on using "_setmode" instead of "setmode", for
the sake of consistency. They both do the same thing, but according to
MSDN documentation, setmode is deprecated.

Fixes bug #14634, reported by Henry Boehlert. Patch by Haribabu Kommi.
Backpatch to all supported versions.

Discussion: https://www.postgresql.org/message-id/20170428082818.24366.13134@wrigleys.postgresql.org
src/bin/pg_basebackup/pg_basebackup.c
src/bin/pg_dump/pg_backup_archiver.c