Fix wrong logic in TransactionIdInRecentPast()
authorAlexander Korotkov <akorotkov@postgresql.org>
Thu, 8 Feb 2024 10:45:26 +0000 (12:45 +0200)
committerAlexander Korotkov <akorotkov@postgresql.org>
Fri, 9 Feb 2024 10:39:42 +0000 (12:39 +0200)
commit18388291aab8038b6abb6a9109ab6763e7a5b630
treef6caa04fd4d6fe0274d954ad610872127de18079
parentd1a2a93766b0a27eb4ffecdb63ed3879088dbfbe
Fix wrong logic in TransactionIdInRecentPast()

The TransactionIdInRecentPast() should return false for all the transactions
older than TransamVariables->oldestClogXid.  However, the function contains
a bug in comparison FullTransactionId to TransactionID allowing full
transactions between nextXid - 2^32 and oldestClogXid - 2^31.

This commit fixes TransactionIdInRecentPast() by turning the oldestClogXid into
FullTransactionId first, then performing the comparison.

Backpatch to all supported versions.

Reported-by: Egor Chindyaskin
Bug: 18212
Discussion: https://postgr.es/m/18212-547307f8adf57262%40postgresql.org
Author: Karina Litskevich
Reviewed-by: Kyotaro Horiguchi
Backpatch-through: 12
src/backend/utils/adt/xid8funcs.c