From 85c2b9a15a1d667b1e2cd580da8c1d9fef0af1e8 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 24 May 2017 16:30:47 -0400 Subject: [PATCH] Code review of get_qual_for_list. We need not consider the case where both nulltest1 and nulltest2 are NULL; the partition either accepts nulls or it does not. Jeevan Ladhe. I added an assertion. --- src/backend/catalog/partition.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c index 7304f6c29ab..7f2fd58462d 100644 --- a/src/backend/catalog/partition.c +++ b/src/backend/catalog/partition.c @@ -1383,15 +1383,14 @@ get_qual_for_list(PartitionKey key, PartitionBoundSpec *spec) if (nulltest1) result = list_make2(nulltest1, opexpr); - else if (nulltest2) + else { Expr *or; + Assert(nulltest2 != NULL); or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1); result = list_make1(or); } - else - result = list_make1(opexpr); return result; } -- 2.30.2