From 818e59373625d194bdec89631b661c4355d15f13 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 30 Mar 2016 13:36:18 -0400 Subject: [PATCH] Suppress uninitialized-variable warnings. My compiler doesn't like the lack of initialization of "flag", and I think it's right: if there were zero keys we'd have an undefined result. The AND of zero items is TRUE, so initialize to TRUE. --- src/backend/utils/adt/geo_spgist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/geo_spgist.c b/src/backend/utils/adt/geo_spgist.c index 7604f1e8eae..cd9db030dcf 100644 --- a/src/backend/utils/adt/geo_spgist.c +++ b/src/backend/utils/adt/geo_spgist.c @@ -515,8 +515,8 @@ spg_box_quad_inner_consistent(PG_FUNCTION_ARGS) for (quadrant = 0; quadrant < in->nNodes; quadrant++) { - bool flag; RectBox *next_rect_box = nextRectBox(rect_box, centroid, quadrant); + bool flag = true; for (i = 0; i < in->nkeys; i++) { @@ -609,7 +609,7 @@ spg_box_quad_leaf_consistent(PG_FUNCTION_ARGS) spgLeafConsistentIn *in = (spgLeafConsistentIn *) PG_GETARG_POINTER(0); spgLeafConsistentOut *out = (spgLeafConsistentOut *) PG_GETARG_POINTER(1); Datum leaf = in->leafDatum; - bool flag; + bool flag = true; int i; /* All tests are exact. */ -- 2.39.5