Reset pg_stat_activity.xact_start during PREPARE TRANSACTION.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 24 Apr 2014 17:29:48 +0000 (13:29 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 24 Apr 2014 17:29:48 +0000 (13:29 -0400)
commitd19bd29f07aef9e508ff047d128a4046cc8bc1e2
tree6c166aa6807b0f56cc864563cf476670c925b623
parentb2c9b161b8ae36dd9972e77297274afb9a675782
Reset pg_stat_activity.xact_start during PREPARE TRANSACTION.

Once we've completed a PREPARE, our session is not running a transaction,
so its entry in pg_stat_activity should show xact_start as null, rather
than leaving the value as the start time of the now-prepared transaction.

I think possibly this oversight was triggered by faulty extrapolation
from the adjacent comment that says PrepareTransaction should not call
AtEOXact_PgStat, so tweak the wording of that comment.

Noted by Andres Freund while considering bug #10123 from Maxim Boguk,
although this error doesn't seem to explain that report.

Back-patch to all active branches.
src/backend/access/transam/xact.c