Remove table AM callback scan_bitmap_next_block
authorMelanie Plageman <melanieplageman@gmail.com>
Sat, 15 Mar 2025 14:37:46 +0000 (10:37 -0400)
committerMelanie Plageman <melanieplageman@gmail.com>
Sat, 15 Mar 2025 14:37:46 +0000 (10:37 -0400)
commitc3953226a07527a1e2f7f410b83e1a7021f42888
treee870af20ddaf1b56c180652dfd51928417775264
parent2b73a8cd33b745c5b8a7f44322f86642519e3a40
Remove table AM callback scan_bitmap_next_block

After pushing the bitmap iterator into table-AM specific code (as part
of making bitmap heap scan use the read stream API in 2b73a8cd33b7),
scan_bitmap_next_block() no longer returns the current block number.
Since scan_bitmap_next_block() isn't returning any relevant information
to bitmap table scan code, it makes more sense to get rid of it.

Now, bitmap table scan code only calls table_scan_bitmap_next_tuple(),
and the heap AM implementation of scan_bitmap_next_block() is a local
helper in heapam_handler.c.

Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/flat/CAAKRu_ZwCwWFeL_H3ia26bP2e7HiKLWt0ZmGXPVwPO6uXq0vaA%40mail.gmail.com
src/backend/access/heap/heapam_handler.c
src/backend/access/table/tableamapi.c
src/backend/executor/nodeBitmapHeapscan.c
src/backend/optimizer/util/plancat.c
src/include/access/tableam.h